Add renewable token providers to the Web API client - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FmsgClient requires an API key today, so an OAuth adapter cannot supply separate, renewable Web API credentials. Accept a caller-bound
TokenProvideralongside the existing API-key string, with a documented provider-neutral contract. The MCP executable retains its current API-key setup; hosted OAuth discovery, validation and token exchange remain follow-up work.The client shares concurrent renewal, pins the authenticated address, cancels acquisition when all waiters cancel or the client closes, and bounds renewal time even if a provider ignores cancellation. Short-lived tokens use a capped refresh margin. Late 401 responses reuse an already renewed token, while protected requests still retry at most once and preserve upstream denials. HTTP and WebSocket helpers use the same credential source.
The provider contract records the upstream requirement that exchanged messaging tokens must not inherit owner key-management privileges. Scope and identity authorization stay in the Web API. Fixture tests exercise credential delivery and isolation; they do not claim OAuth conformance or real-IdP compatibility.
Validation: